Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle library without React #112

Closed
bedrich-schindler opened this issue Jun 18, 2020 · 0 comments · Fixed by #58
Closed

Bundle library without React #112

bedrich-schindler opened this issue Jun 18, 2020 · 0 comments · Fixed by #58
Labels
BC Breaking change bug Something isn't working refactoring
Milestone
v0.32.0

Comments

@bedrich-schindler
Copy link
Contributor

In #58, we met problem with duplicate React instances when using hooks. If ReactUI is bundled together with React than consumer meets error that duplicate React instances are found.

Problem should be solved when react and react-dom (it is not necessary, but it reduces bundle size) are marked as external in webpack configuration: https://webpack.js.org/configuration/externals/
@bedrich-schindler bedrich-schindler added bug Something isn't working proposal refactoring BC Breaking change and removed proposal labels Jun 18, 2020
@bedrich-schindler bedrich-schindler added this to the v0.32.0 milestone Jun 18, 2020
@bedrich-schindler bedrich-schindler linked a pull request Jun 18, 2020 that will close this issue
ScrollView #58
Merged
bedrich-schindler added a commit that referenced this issue Jun 19, 2020
@bedrich-schindler
Configure webpack to bundle library without react and react-dom, …
5f94b9d 
…let fail build when set size is exceeded (#112)
adamkudrna pushed a commit that referenced this issue Jun 25, 2020
@bedrich-schindler @adamkudrna
Configure webpack to bundle library without react and react-dom, …
9bf47e3 
…let fail build when set size is exceeded (#112)
adamkudrna pushed a commit that referenced this issue Jun 25, 2020
@bedrich-schindler @adamkudrna
Configure webpack to bundle library without react and react-dom, …
8679570 
…let fail build when set size is exceeded (#112)
adamkudrna pushed a commit that referenced this issue Jun 25, 2020
@bedrich-schindler @adamkudrna
Configure webpack to bundle library without react and react-dom, …
7a0dfe5 
…let fail build when set size is exceeded (#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Breaking change bug Something isn't working refactoring
Projects
None yet
Milestone
v0.32.0
Development

Successfully merging a pull request may close this issue.

ScrollView react-ui-org/react-ui
1 participant
@bedrich-schindler