[TypeScript] Add ScreenProps type and export it #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjgf
changed the title
|
great! thank you |
|
@itsjgf - are you interested in becoming a collaborator on this org to continue helping with typescript types? it'd be great to have you |
|
@brentvatne sure! I will be happy to help =). |
|
@itsjgf - invited you to the repo :) https://github.com/react-navigation/react-navigation/invitations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
screenPropsprop doesn't have a clear type (sometimes it's typed withobject, other times withanyand others with{ [key: string]: any }).This PR creates and exports a custom
ScreenPropstype for better consistency.