Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native new architecture support done in android and ios #526

Merged
merged 8 commits into from
Feb 24, 2025

Conversation

SolankiYogesh
Copy link
Contributor

No description provided.

@sanduluca
Copy link

Seems to be working with react native 0.76.6 with new architecture ON, on android (android 13). Will return later with update for iOS

@djMax
Copy link

djMax commented Feb 2, 2025

Anxiously awaiting this one!

@prasad-marne

This comment was marked as duplicate.

1 similar comment
@SiddharthMalviya18

This comment was marked as duplicate.

@Johan-dutoit
Copy link
Collaborator

Johan-dutoit commented Feb 18, 2025

@SolankiYogesh any chance you can spend time to get the CI actions to pass?
As this won't publish if the actions aren't working

Got the checks to all pass. I'm trying to test this locally before pushing.

Replaced the example app (with upgraded React Native), due to android build issues.
Both apps run now, but not getting either of them to work
All seems to work fine!

Update config.yml

Use latest pipeline orb

Update config.yml

use node 18

Update config.yml

use node 18.18.0

Update .gitignore

ignore .xcode.env.local

Delete example/ios/.xcode.env.local

delete

Update config.yml

Update config.yml

use node_version 20.8.1

fix: add prettier and clean up lock file

fix: eslint issues

chore: bump node again
@Johan-dutoit Johan-dutoit merged commit 6ae9c96 into react-native-voice:master Feb 24, 2025
3 checks passed
@Johan-dutoit
Copy link
Collaborator

CI failed to publish due to not having a valid GH Token, only @safaiyeh can fix this afaik (both due to circleci access and npm publish access)

@39km
Copy link

39km commented Feb 26, 2025

Is there any update for publish new version?

@ct-els-salvit1
Copy link

not working for me, any new version publish or same version?, cannot see any changes in node_module for this npm.

@sanduluca
Copy link

You can install directly from git until a new version will be published

npm install <url>#<hash>
yarn add <url>#<hash>

example:

yarn add https://github.com/react-native-voice/voice#6ae9c96164d2b9e98dd8f308e09c0fceb2b9199a
npm install https://github.com/react-native-voice/voice#6ae9c96164d2b9e98dd8f308e09c0fceb2b9199a

@ct-els-salvit1
Copy link

@sanduluca look like the code implementation is also change to call, any example or readme.
image

@39km
Copy link

39km commented Feb 26, 2025

@sanduluca it works well! thank you so much 🙏

@marsakt
Copy link

marsakt commented Feb 26, 2025

yarn add https://github.com/react-native-voice/voice#6ae9c96164d2b9e98dd8f308e09c0fceb2b9199a

I used this, unfortunately it's not possible to use it with expo build :-\ there is some error.

but I have question: do you know how challenging is to fix a build/publish? do not have any experience with public repos / configuration etc.? pls @safaiyeh can you look at it?

@Johan-dutoit
Copy link
Collaborator

We've been trying for~2 weeks to get hold of @safaiyeh , who seems to be the only one with access to this package's CircleCI and NPM.

Will likely have to publish this as a new package on NPM unfortunately, however before doing so, I'm giving it some more time in hopes of @safaiyeh seeing some of our messages and sorting it all out.

@safaiyeh
Copy link
Member

We've been trying for~2 weeks to get hold of @safaiyeh , who seems to be the only one with access to this package's CircleCI and NPM.

Will likely have to publish this as a new package on NPM unfortunately, however before doing so, I'm giving it some more time in hopes of @safaiyeh seeing some of our messages and sorting it all out.

Happy to transfer ownership of everything to you. Send me an email [email protected]

@Johan-dutoit
Copy link
Collaborator

Email sent @safaiyeh
Thanks!

@shishir-promact
Copy link

Hello @safaiyeh @Johan-dutoit Any update for the npm release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.