fix: make watch work in all platform #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see it in action with WSL2 in the following YouTube video:
|
|
unlinking is not yet working properly on Windows. Will update the PR shortly |
Use `chokidar` to track file system changes as soon it will throw an
error if the platform does not support `{ recursive: true }`.
Fix also an error where the built file was not being deleted when the
source was removed.
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Fix react-native-community#989
Ref: nodejs/node#29947
|
This is working properly now on Linux and Windows and I hope on mac as well 😊 |
thymikee
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use
chokidarto track file system changes as soon it will throw anerror if the platform does not support
{ recursive: true }.Fix also an error where the built file was not being deleted when the
source was removed.
Fix #989
Ref: nodejs/node#29947
Test Plan:
N/A