refactor: use the cli-server-api package #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Apr 27, 2020
| @@ -9,13 +9,13 @@ | |||
| import Metro from 'metro'; | |||
There was a problem hiding this comment.
Can we also rename the directory from server to start now that most of the implementation moved to other package? I think it's a good moment to make it happen and be consistent with other commands
There was a problem hiding this comment.
Sure, renamed the directory to commands/start.
thymikee
force-pushed
the
use-dev-server-api
branch
from
8bbe167 to
d768303
Compare
|
Noticed an issue with "Reload app" button in Chrome (works fine with Flipper), opening another debugger tab unnecessarily. Same when pressing Reload from an app. Tested on Android |
Esemesek
approved these changes
May 8, 2020
thymikee
reviewed
May 8, 2020
| @@ -79,6 +79,7 @@ export function createDevServerMiddleware(options: MiddlewareOptions) { | |||
| '/message', | |||
| ); | |||
| broadcast = messageSocket.broadcast; | |||
| isDebuggerConnected = debuggerProxy.isDebuggerConnected; | |||
There was a problem hiding this comment.
cc @fson the debugger connected state was not updated, likely an oversight when moving code around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The development server middleware and WebSocket servers were extracted out to the
@react-native-community/cli-server-apipackage in #1118. This PR makes the CLI use that package and removes any remaining duplicates of these modules that have been moved.Test Plan:
Followed the Testing your changes instructions in
CONTRIBUTING.mdand started the server withnpx react-native start --watchFolders /Users/ville/Projects/react-native-cli/ --resetCache. Verified the following features work:r