Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new hook usePermission #143

Merged
merged 1 commit into from
Jun 22, 2021
Merged

feat: new hook usePermission #143

merged 1 commit into from
Jun 22, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 21, 2021

What new hook does?

Tracks a permission state.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the 🎂 new hook New hook added label Jun 21, 2021
@xobotyi xobotyi requested a review from JoeDuncko June 21, 2021 06:21
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #143 (513b404) into master (a84b3a6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        37    +5     
  Lines          524       588   +64     
  Branches        96       105    +9     
=========================================
+ Hits           524       588   +64
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/useDebouncedCallback/useDebouncedCallback.ts 100.00% <100.00%> (ø)
src/usePermission/usePermission.ts 100.00% <100.00%> (ø)
src/useThrottledCallback/useThrottledCallback.ts 100.00% <100.00%> (ø)
src/useAsync/useAsync.ts 100.00% <0.00%> (ø)
src/useSafeState/useSafeState.ts 100.00% <0.00%> (ø)
src/useDebouncedEffect/useDebouncedEffect.ts 100.00% <0.00%> (ø)
src/useThrottledEffect/useThrottledEffect.ts 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131d98e...513b404. Read the comment docs.

JoeDuncko
JoeDuncko approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@JoeDuncko JoeDuncko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xobotyi xobotyi merged commit 9eb06f4 into master Jun 22, 2021
@xobotyi xobotyi deleted the usePermission branch June 22, 2021 14:04
github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
5881c3f 
# [3.2.0](v3.1.0...v3.2.0) (2021-06-22)

### Features

* new hook `usePermission` ([#143](#143)) ([9eb06f4](9eb06f4))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jun 22, 2021

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko