Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headerAlign and bodyAlign #155

Closed
wants to merge 1 commit into from

Conversation

marswong
Copy link

@marswong marswong commented Aug 13, 2017

@benjycui refer to ant-design/ant-design#2465, and #137 can be closed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.326% when pulling 9a3416d on marswong:master into 7b5e1a6 on react-component:master.

@marswong marswong changed the title feat: add headerAlign and bodyAlign(ant-design/ant-design#2465) feat: add headerAlign and bodyAlign Aug 13, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.326% when pulling 9589a5e on marswong:master into 7b5e1a6 on react-component:master.

@afc163
Copy link
Member

afc163 commented Aug 14, 2017

columns={[{
  'align': 'left',
}]}

This will be better.

@marswong
Copy link
Author

marswong commented Aug 14, 2017

I thought about this, seperated config is flexible, but uncommon in daily usage.
Such as the statistic data always need a table with unified center-aligned table head and right-aligned table body.
So it may be better to expose a unified config API, and if really needed, users can just set text-align in the column render function, but it's really uncommon

@afc163
Copy link
Member

afc163 commented Aug 31, 2017

It is a common usage for sepecify align for one column: https://ant.design/components/table/#components-table-demo-bordered So #137 maybe a better solution for it.

@marswong
Copy link
Author

marswong commented Sep 1, 2017

Got it.

@marswong marswong closed this Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants