fix: add tabIndex support #779
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Could you add a test case? |
|
@afc163 I've added some simple tests for |
|
Contained conflicting files |
wang-yikai
force-pushed
the
fix-tabIndex-input
branch
from
477c6bf to
cb7e3ed
Compare
|
@afc163 I fixed the conflicts. Let me know if you can merge this pull request, thanks! |
|
Hi all, I'd like to know if there is more to be done regarding this PR. Happy to contribute in any way I can to get this merged. |
|
@Chevindu Can you resolve the conflicts (https://github.com/react-component/picker/pull/779/conflicts) and merge my pull request? The conflict is just the import order which should've been resolved by my latest push (https://github.com/react-component/picker/compare/477c6bf8899a308c1d5a1f464f465defc5dcfccb..cb7e3ed5383efe7a1f707d7e705b4982e298fe27). |
|
@wang-yikai I don't have that access to either the main repo or your fork. Will you please be able to rebase/merge from the upstream master and add another commit? I think that should resolve all conflicts. |
wang-yikai
force-pushed
the
fix-tabIndex-input
branch
from
cb7e3ed to
efa978a
Compare
|
@Chevindu I've just made a push in my fork. The conflicts should be resolved now. Let me know if you're able to merge, thank you! |
|
@wang-yikai Thank you. But I do not have that privilege. @afc163 Will you kindly be able look into this? |
I've created this pull request to fix ant-design/ant-design#48059