Add support for Windows hosts #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the WMIC command line available starting with Windows Vista/Server 2003 to query for CPU cores and memory.
|
@rdsubhas Are there issues with this change? |
|
Is this project still maintained? |
|
Hi @mbrodala Sorry for the late response... Am looking at this... |
|
Awesome! This looks good, will publish a new version. Thanks! |
rdsubhas
added a commit
that referenced
this pull request
Mar 14, 2015
Add support for Windows hosts
|
No worries, thanks a lot. :-) |
|
@rdsubhas Could you publish the new version on RubyGems? |
|
@mbrodala Very sorry, I had some machine problems, had some difficulties publishing a vagrant plugin while running the whole thing under Vagrant itself :) Added travis to sort it out and the new version is published. Thanks for your contrib and patience! |
|
Thanks a lot. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the WMIC command line utility available starting with Windows Vista/Server 2003 to query for CPU cores and memory.