Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short title for Section and Page #1017

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Short title for Section and Page #1017

merged 3 commits into from
Jul 2, 2024

Conversation

jochenklar
Copy link
Member

This PR adds a new field short_title to Section and Page. If set, this field populates the navigation instead of the title which might be to long. See also #363 and #346.

@jochenklar jochenklar requested a review from MyPyDavid June 6, 2024 16:07
@jochenklar jochenklar self-assigned this Jun 6, 2024
@jochenklar jochenklar added this to the RDMO 2.2.0 milestone Jun 6, 2024
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are missing, even though it's mainly Django and DRF stuff

@MyPyDavid
Copy link
Member

I think I would need to add this to the import (#810) afterwards as well

@jochenklar
Copy link
Member Author

jochenklar commented Jun 20, 2024

No sorry I don't think we need tests here. The only thing which could be tested is that short_title is used and not title if it is set. I don't want to mess with the fixtures just for that. 😕

@jochenklar
Copy link
Member Author

Ah crap and to the export!

@MyPyDavid
Copy link
Member

yes, I think to have a model field represented in a test fixture should be a minimum or not??

@jochenklar
Copy link
Member Author

I don't think we need that every time. We need to update the fixtures and the xml files at one point in the future, but not now.

@jochenklar
Copy link
Member Author

Force push after interactive rebase.

@jochenklar jochenklar requested a review from MyPyDavid June 20, 2024 13:02
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jochenklar jochenklar merged commit 973173a into dev-2.2.0 Jul 2, 2024
17 checks passed
@jochenklar jochenklar deleted the short_title branch July 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants