-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support generic MeshFileGeometry for mesh types we can't easily load #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
+ Coverage 73.2% 73.41% +0.2%
=========================================
Files 12 12
Lines 321 331 +10
=========================================
+ Hits 235 243 +8
- Misses 86 88 +2
Continue to review full report at Codecov.
|
Just so I understand, what would be the drawbacks of using this always if the source of the mesh is a file on disk, e.g. in |
There's really not much downside at all, and you're right that it doesn't matter whose computer has the mesh since we send the entire contents. The only real problem is that it's not totally obvious what a mesh file represents. Is it just a geometry? Many formats support materials and/or textures. But some formats (like DAE) can represent an entire scene with all sorts of behavior attached to it. So it's a little ambiguous to ask meshcat to render a file when that file contains more than just a single mesh geometry. However, we already have that problem, as MeshIO assumes that a single mesh file produces a single But, all told, this is as good as any solution we currently have available, so we should certainly use it if it's convenient. |
How do you think we should handle this in MechanismGeometries? MechanismGeometries is viewer-agnostic (as it should be), so it wouldn't have access to How about this:
|
That all sounds good to me, although I think we should consider dropping DrakeVisualizer support entirely. I'm happy to keep things viewer-agnostic, but I have no interest in using DrakeVisualizer and don't really want to keep adding features to it. |
Yep, sounds good. I can put some PRs together. I'm actually hoping this will also help with latency. |
TODO: