Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host kwarg to open() and add some documentation #89

Merged
merged 5 commits into from
Feb 9, 2019

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Feb 8, 2019

This PR builds on top of #86 and fixes the merge conflicts that I recently introduced into master. It also adds some documentation for the open() function.

@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   70.14%   69.73%   -0.42%     
==========================================
  Files          12       12              
  Lines         335      337       +2     
==========================================
  Hits          235      235              
- Misses        100      102       +2
Impacted Files Coverage Δ
src/MeshCat.jl 28% <ø> (ø) ⬆️
src/servers.jl 4.16% <0%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2f5c7...925ec88. Read the comment docs.

@rdeits rdeits merged commit 6b06294 into master Feb 9, 2019
@rdeits rdeits deleted the host-addr-kwarg branch February 9, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants