Add keyword for starting the browser #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would prefer the
open()
function not starting the browser, so I added a keyword to skip that part. The default behaviour does not change. The keyword is:start_browser
, I have several other ideas (open_url
oropen_browser
oropen_in_browser
), but could not select from them, because the function isopen()
and adding a kwarg likeopen_...
seems odd.I have concerns about type instability at the
start_browser && open_url(url)
line, but don't know if it's true and/or it is a problem, as it (in theory) runs once per session.I also didn't included it into the demo or docs, because the other kwargs are also excluded.