Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword for starting the browser #84

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

cserteGT3
Copy link
Contributor

It would prefer the open() function not starting the browser, so I added a keyword to skip that part. The default behaviour does not change. The keyword is: start_browser, I have several other ideas (open_url or open_browser or open_in_browser), but could not select from them, because the function is open() and adding a kwarg like open_... seems odd.
I have concerns about type instability at the start_browser && open_url(url) line, but don't know if it's true and/or it is a problem, as it (in theory) runs once per session.
I also didn't included it into the demo or docs, because the other kwargs are also excluded.

@codecov-io
Copy link

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files          12       12           
  Lines         334      334           
=======================================
  Hits          234      234           
  Misses        100      100
Impacted Files Coverage Δ
src/servers.jl 4.54% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c701d...725ed13. Read the comment docs.

@tkoolen
Copy link
Collaborator

tkoolen commented Jan 22, 2019

@rdeits, any comments? I think this is reasonable.

@rdeits
Copy link
Owner

rdeits commented Feb 8, 2019

This looks great to me. Thank you, and sorry for the delay in responding!

@rdeits rdeits merged commit 2716096 into rdeits:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants