added setobject! for HomogenousMesh that uses the color in HMesh

[ryanelandt]

No description provided.

[codecov-io]

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #62   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files          12    12           
  Lines         301   306    +5     
====================================
- Misses        301   306    +5

Impacted Files	Coverage Δ
src/abstract_visualizer.jl	0% <ø> (ø)	⬆️
src/objects.jl	0% <0%> (ø)	⬆️
src/geometry.jl	0% <0%> (ø)	⬆️
src/servers.jl	0% <0%> (ø)	⬆️
src/trees.jl	0% <0%> (ø)	⬆️
src/MeshCat.jl	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418d5b3...c70f656. Read the comment docs.

[tkoolen]

Could you add a test that covers this code?

[ryanelandt]

Added one. I'll work on getting better at remembering to do that.

[tkoolen]

Thanks, looks good to me. @rdeits?

[rdeits]

Thanks @ryanelandt! I actually would prefer to move this logic around a bit--having a specialization for setobject! seems a bit odd, but we can implement the same behavior by instead implementing Object(g::HomogenousMesh) which is internally called by setobject!. That makes a bit more sense to me and has the further benefit of being something we can test more easily.

[rdeits]

I'll open a PR against your branch with the change I'm proposing.

[ryanelandt]

Adding MeshCat.material fixes the tests on all versions but 0.6. I don't know why the color isn't being set of 0.6.

Alternatively, removing the 0.6 tests from Travis will fix this issue.

[rdeits]

Hm, that's very strange. I'll check it out locally. I'd rather not drop 0.6 just because we don't understand what's going on.

[rdeits]

Oh, looks like a GoemetryTypes bug that got fixed since the last 0.6 compatible version. The color argument to HomogenousMesh just doesn't seem to do anything. I'll update our test to avoid the issue.

That said, I'm open to dropping 0.6 support from MeshCat whenever it's convenient to do so.

[ryanelandt]

The Julia newsletter this morning included the announcement of JuliaPro 1.0.1.1. This might be one of those times.

[rdeits]

(re-opening this to trigger the tests again)