Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings RotMatrix from Rotations.jl into scope #169

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Brings RotMatrix from Rotations.jl into scope #169

merged 1 commit into from
Sep 2, 2020

Conversation

ferrolho
Copy link
Collaborator

@ferrolho ferrolho commented Jul 6, 2020

Addresses issue #168.

Copy link
Owner

@rdeits rdeits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge this when CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #169 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   78.89%   78.63%   -0.27%     
==========================================
  Files          18       18              
  Lines         507      482      -25     
==========================================
- Hits          400      379      -21     
+ Misses        107      103       -4     
Impacted Files Coverage Δ
src/MeshCat.jl 80.00% <ø> (ø)
src/msgpack.jl 16.66% <0.00%> (-66.67%) ⬇️
src/lowering.jl 89.23% <0.00%> (-6.30%) ⬇️
src/geometry.jl 95.65% <0.00%> (-4.35%) ⬇️
src/trees.jl 92.59% <0.00%> (-3.71%) ⬇️
src/atframe.jl 84.84% <0.00%> (-0.45%) ⬇️
src/assets.jl 0.00% <0.00%> (ø)
src/objects.jl 100.00% <0.00%> (ø)
src/integrations.jl 100.00% <0.00%> (ø)
src/arrow_visualizer.jl 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c435c...6bd1c73. Read the comment docs.

@rdeits
Copy link
Owner

rdeits commented Sep 2, 2020

Sorry--apparently I forgot to merge this. I'll do that right now!

@rdeits rdeits merged commit 7eccff7 into rdeits:master Sep 2, 2020
@ferrolho
Copy link
Collaborator Author

ferrolho commented Sep 2, 2020

No problem! 🙂 Thank you for merging this.

@ferrolho
Copy link
Collaborator Author

ferrolho commented Sep 2, 2020

(@rdeits, off-topic: I tried to reach you on JuliaLang's Slack; do you still check it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants