Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to the latest meshcat js #123

Merged
merged 10 commits into from
Oct 10, 2019
Merged

update to the latest meshcat js #123

merged 10 commits into from
Oct 10, 2019

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Aug 5, 2019

@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #123 into master will increase coverage by 3.25%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #123      +/-   ##
=========================================
+ Coverage   76.04%   79.3%   +3.25%     
=========================================
  Files          14      15       +1     
  Lines         405     459      +54     
=========================================
+ Hits          308     364      +56     
+ Misses         97      95       -2
Impacted Files Coverage Δ
src/visualizer.jl 73.23% <33.33%> (+3.9%) ⬆️
src/util.jl 100% <0%> (ø)
src/MeshCat.jl 33.33% <0%> (+2.89%) ⬆️
src/animations.jl 80.85% <0%> (+4.66%) ⬆️
src/atframe.jl 82.35% <0%> (+5.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bec32...08a73fb. Read the comment docs.

@rdeits
Copy link
Owner Author

rdeits commented Aug 5, 2019

Blocked by JuliaGizmos/WebIO.jl#337 🙁

@tkoolen
Copy link
Collaborator

tkoolen commented Aug 5, 2019

Also blocked by #115 (comment), sorry.

@tkoolen
Copy link
Collaborator

tkoolen commented Aug 5, 2019

Fix for #115 (comment) in #124.

…lot of geometries are loaded without an open visualizer by increasing outbox size.
[PR against rd/update-js] updates to match WebIO.
@tkoolen
Copy link
Collaborator

tkoolen commented Sep 6, 2019

JuliaLang/MbedTLS.jl#208

@rdeits
Copy link
Owner Author

rdeits commented Sep 8, 2019

I think the "explicit requirement" that is restricting MbedTLS to an incompatible version must be coming from the Manifest.toml. It's likely that there isn't a single Manifest.toml that will give compatible versions for Julia 1.0, 1.1, and 1.2, so perhaps this is a case where being over-cautious by storing the Manifest is not helping. I'm going to try just removing the Manifest from the repo to see if that gets things working again.

@rdeits
Copy link
Owner Author

rdeits commented Sep 8, 2019

There's still something wrong here. The test/visualizer.jl tests are supposed to render the same scene in a browser window and a Blink window, but now the browser websocket connection closes and doesn't render anything. There might be something broken in the Mux integration. Boo.

@rdeits
Copy link
Owner Author

rdeits commented Sep 8, 2019

This might be JuliaGizmos/WebIO.jl#343

@tkoolen
Copy link
Collaborator

tkoolen commented Sep 9, 2019

Ah, I guess I was working around that issue with 1108156. This is quite the saga.

@rdeits
Copy link
Owner Author

rdeits commented Oct 10, 2019

Given that things are subtly broken in master (ref #127 ) and this is a step in the right direction, I'm going to merge this PR and then work on things from there.

@rdeits rdeits merged commit aea1011 into master Oct 10, 2019
@rdeits rdeits deleted the rd/update-js branch October 10, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants