Add lower bound on Cassette. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.2.5. contains JuliaLabs/Cassette.jl#137, which we ran into when using Cassette-based animation in MeshCatMechanisms. Might as well lower-bound Cassette here, as other dependencies could run into the same issue, and it doesn't really make sense to add Cassette as a direct dependency to MeshCatMechanisms just to lower-bound it.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 76.04% 76.04%
=======================================
Files 14 14
Lines 405 405
=======================================
Hits 308 308
Misses 97 97Continue to review full report at Codecov.
|
tkoolen
added a commit
to JuliaRobotics/MeshCatMechanisms.jl
that referenced
this pull request
Aug 5, 2019
MeshCat lower bound also takes care of Cassette lower bound, rdeits/MeshCat.jl#117.
tkoolen
added a commit
to JuliaRobotics/MeshCatMechanisms.jl
that referenced
this pull request
Aug 5, 2019
MeshCat lower bound also takes care of Cassette lower bound, rdeits/MeshCat.jl#117.
tkoolen
added a commit
to JuliaRobotics/MeshCatMechanisms.jl
that referenced
this pull request
Jan 9, 2020
* Update to new atframe signature. * Work around JuliaLabs/Cassette.jl#89. * Bump MeshCat lower bound, undo reverse workaround. MeshCat lower bound also takes care of Cassette lower bound, rdeits/MeshCat.jl#117.
tkoolen
added a commit
to JuliaRobotics/MeshCatMechanisms.jl
that referenced
this pull request
Jan 9, 2020
MeshCat lower bound also takes care of Cassette lower bound, rdeits/MeshCat.jl#117.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.2.5. contains JuliaLabs/Cassette.jl#137, which
we ran into when using Cassette-based animation in MeshCatMechanisms.
Might as well lower-bound Cassette here, as other dependencies could run
into the same issue, and it doesn't really make sense to add Cassette as
a direct dependency to MeshCatMechanisms just to lower-bound it.