Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Personal Proxy Update #383

Merged
merged 16 commits into from
Apr 4, 2022
Merged

Personal Proxy Update #383

merged 16 commits into from
Apr 4, 2022

Conversation

Risewill23
Copy link
Collaborator

@Risewill23 Risewill23 commented Apr 4, 2022

Suggestion from #343

thoroc
thoroc previously requested changes Apr 4, 2022
@Risewill23 Risewill23 requested a review from thoroc April 4, 2022 20:07
@Risewill23
Copy link
Collaborator Author

The changes need reviewed too I guess

Copy link
Collaborator

@ixi2101 ixi2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've added the name=None to the function calls instead of the definition

@Risewill23 Risewill23 dismissed thoroc’s stale review April 4, 2022 20:14

Already fixed it

@Risewill23
Copy link
Collaborator Author

Can you review/approve the change request now?

@ixi2101
Copy link
Collaborator

ixi2101 commented Apr 4, 2022

Have you tested it working? I can't test rn

@Risewill23
Copy link
Collaborator Author

yes like right after I made the last change

@Risewill23
Copy link
Collaborator Author

thanks

@ixi2101
Copy link
Collaborator

ixi2101 commented Apr 4, 2022

Linting is broken dw about that

@Risewill23
Copy link
Collaborator Author

Risewill23 commented Apr 4, 2022

I already looked at the logs and saw that

@Risewill23 Risewill23 merged commit 713c2c6 into main Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can someone approve my PR? (r/place is about to end and it has a very important bug fix)
3 participants