Fix #64 by quoting functions and set IFS on read #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes bug where IFS in outer environment could be set to something that would cause our inner functions to break on varibale expansion. - Added a couple unit tests.
This was referenced Jan 15, 2018
dimo414
reviewed
Jan 15, 2018
| @@ -106,7 +106,7 @@ __bp_precmd_invoke_cmd() { | |||
| # Test existence of functions with: declare -[Ff] | |||
| if type -t "$precmd_function" 1>/dev/null; then | |||
| __bp_set_ret_value "$__bp_last_ret_value" "$__bp_last_argument_prev_command" | |||
| $precmd_function | |||
| "$precmd_function" | |||
There was a problem hiding this comment.
It would be good to leave a comment in the file somewhere noting why we need to quote function names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where IFS in outer environment could be set to something that
would cause our inner functions to break on varibale expansion.
Added a couple unit tests.