Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add await using Declarations and AsyncDisposableStack #3

Merged

Conversation

rbuckton
Copy link
Owner

@rbuckton rbuckton commented Jan 27, 2023

This PR contains the Stage 2 specification text for Async Explicit Resource Management. If Async Explicit Resource Management advances to Stage 3, it's possible this may be merged with tc39#3000 to streamline advancement due to the layering of these proposals.

NOTE: esmeta checks for this PR won't succeed until we've updated the build process to use a version of esmeta containing es-meta/esmeta#134.

@michaelficarra
Copy link

NOTE: esmeta checks for this PR won't succeed until we've updated the build process to use a version of esmeta containing es-meta/esmeta#134.

If you let me know when they tag a release, I'll bump esmeta. For now, that commit hasn't even landed on their main branch yet, so I'm not inclined to depend on it.

@rbuckton rbuckton force-pushed the async-explicit-resource-management branch 5 times, most recently from e1022da to 3bf0948 Compare January 30, 2023 21:20
@rbuckton rbuckton force-pushed the async-explicit-resource-management branch from 3bf0948 to 140e02c Compare January 31, 2023 19:07
rbuckton pushed a commit that referenced this pull request Feb 5, 2023
@rbuckton
Copy link
Owner Author

@michaelficarra apparently es-meta/esmeta#134 was included in 0.3.3, though it doesn't show up in the release notes.

@michaelficarra
Copy link

@rbuckton It appears we are already using 0.3.3 in ecma262 CI: https://github.com/tc39/ecma262/blob/main/.github/workflows/esmeta-typecheck.yml#L27

Is there anything else I need to do here?

@rbuckton rbuckton force-pushed the async-explicit-resource-management branch from 57272ef to 716bb8a Compare March 22, 2024 17:37
@rbuckton
Copy link
Owner Author

Is there anything else I need to do here?

It doesn't look like it, no.

@rbuckton rbuckton marked this pull request as ready for review March 22, 2024 18:06
@rbuckton
Copy link
Owner Author

This should now be up to date with the current consensus spec text, so I will merge this into the main PR.

@rbuckton rbuckton changed the title Add using await Declarations and AsyncDisposableStack Add await using Declarations and AsyncDisposableStack Mar 22, 2024
@rbuckton rbuckton merged commit d79a186 into explicit-resource-management Mar 22, 2024
5 of 7 checks passed
@rbuckton rbuckton deleted the async-explicit-resource-management branch March 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants