Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-4240 - Snapshots are failing on Windows #3

Merged
merged 2 commits into from
Jul 26, 2023
Merged

NET-4240 - Snapshots are failing on Windows #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e244b0
skip sync parent dir for windows are there is not support for directo…
absolutelightning Jul 24, 2023
51a3d40
added comment
absolutelightning Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions safeio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"io"
"os"
"path/filepath"
"runtime"
)

// WriteToFile consumes the provided io.Reader and writes it to a temp
Expand Down Expand Up @@ -85,6 +86,11 @@ func Rename(oldname, newname string) error {
}

func syncParentDir(name string) error {
// Skipping sync dir for windows
// because it is not supported.
if runtime.GOOS == "windows" {
return nil
}
f, err := os.Open(filepath.Dir(name))
if err != nil {
return err
Expand Down