invoke make update-gems before make install with ruby-trunk #1098
Conversation
bin/ruby-build
Outdated
| } >&4 2>&1 | ||
|
|
||
| if [ "$package_name" == "ruby-trunk" ]; then | ||
| { "$MAKE" update-gems |
There was a problem hiding this comment.
If I remember correctly, it's also necessary to execute "$MAKE" extract-gems to use bundled gems when manually building ruby, isn't it? Not sure, just confirmation.
There was a problem hiding this comment.
Rather than checking package_name, perhaps we could introduce a separate standard_from_source build step that handles the gem update and anything else specific to building from source rather than from a distribution tarball.
Better yet, if the standard step were composed of separate standard_build and standard_install steps, then we could reuse standard_build and just introduce a new standard_install_from_source that performs the gem update before invoking standard_install.
Then our build def would look like
install_git "ruby-trunk" "https://github.com/ruby/ruby.git" "trunk" ldflags_dirs autoconf standard_build standard_install_from_source verify_openssl
|
@jeremy Looks good. I'm going to update with your suggestion. |
* standard_build invoke configure and make. It not invoke `make install`. * standard_install invoke only `make install`. * Added backword compatibility function for above separation. * Added new function for bundled_gems support named standard_install_with_bundled_gems.
… versions that has bundled gems
|
@k0kubun Can you try this branch for installing bundled gems? |
$ rbenv install 2.5.0-dev
Cloning https://github.com/ruby/ruby.git...
Installing ruby-trunk...
Installed ruby-trunk to /home/k0kubun/.rbenv/versions/2.5.0-dev
$ rbenv shell 2.5.0-dev
$ irb
irb(main):001:0> require 'minitest'
=> true@hsbt It worked! Thanks. |
Main change is replication of: rbenv/ruby-build#1098 * tag 'ruby-build/v20170726': bump version to v20170726 Add rbx-3.81 and rbx-3.82 Add definition for JRuby 9.1.12.0 Add definition for JRuby 9.1.11.0 Added gitignore for bats repository Ruby 2.2 entered unsupported security maintenance on 2016-12-25 Ruby 2.1 reached end of life on 2017-03-31 Improve check for openssl on macOS Pass arguments for separated functions To use standard_build and standard_install_with_bundled_gems for ruby versions that has bundled gems Separated standard function to standard_build and standard_install. invoke extract-gems after update-gems Add rbx-3.76, rbx-3.77, rbx-3.78, rbx-3.79 and rbx-3.80 invoke make update-gems before make install with ruby-trunk Ignore LibreSSL bundled with macOS 10.13 Add JRuby 1.7.27 Add definition for JRuby 9.1.10.0 Upgrade to OpenSSL 1.1.0f Upgrade to OpenSSL 1.0.2l
rbenv-prefix: do not silence rbenv-which for system version
Fixes #1093
Added
make update-gemscommand beforemake installwhen installing to 2.5.0-dev named "ruby-trunk"/cc @k0kubun
I'm not a familiar with shell script. Can I handle ruby-trunk, ruby-2.4.0-dev and ruby-2.3.0-dev smartly?