Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage-plugin): add some updates #2515

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kamleshchandnani
Copy link
Collaborator

Description

Updates to coverage plugin

  • Add Card check for border radius
  • Add tokens to coverage % calculation
  • Add Frame check to flag frames for custom components
  • Add check for override of tokens

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 560975c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Jan 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 560975c:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
BladeProvider 1.707 1.709 +0.002 KB
BottomNav, BottomNavItem 1.098 1.096 -0.002 KB

Generated by 🚫 dangerJS against 696a36b

Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamleshchandnani we can merge this?

@@ -19,7 +19,7 @@
"devDependencies": {
"@create-figma-plugin/build": "2.5.0",
"@create-figma-plugin/tsconfig": "2.5.0",
"@figma/plugin-typings": "1.85.0",
"@figma/plugin-typings": "1.107.0-beta.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants