feat(Tabs): Support icon-only tab #2496
Conversation
saurabhdaware
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
tewarig
as code owners
|
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4135b63:
|
| @@ -59,7 +59,7 @@ type TabItemProps = { | |||
| /** | |||
| * The label of the tab item. | |||
| */ | |||
| children: React.ReactNode; | |||
| children?: React.ReactNode; | |||
There was a problem hiding this comment.
Let's add accessibilityLabel prop
|
height of the Tabs seems to be changed breaking the existing examples 
|
|
This looks a bit too wide, Is it just taking the parent component's width? 
|
These changes are taken from Figma. We have changed paddingTop in the case of Tabs. Discussed this with ~RK, and we will do these in a different PR after FTX. |
yes it's parent is a box with width 200px |
| ? React.Children.map(children, (child) => { | ||
| return <>{child}</>; |
There was a problem hiding this comment.
Is this not same as children?
There was a problem hiding this comment.
We also won't need that if-else check itself if this is just children
Description
This pr -
add support for icons only
fixes alignment of icon
fixes border radius of tabs
removes divider from tablist
updates border color
updates padding
updates type
Changes
Additional Information
Component Checklist