feat(Table): add virtualization #2489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
203
to
210
| const isVirtualized = (React.isValidElement<{ | ||
| header?: () => React.ReactElement; | ||
| children?: React.ReactNode; | ||
| }>(tableRootComponent) && | ||
| Array.isArray(tableRootComponent.props?.children) && | ||
| tableRootComponent.props.children?.length && | ||
| React.isValidElement<{ children?: React.ReactNode }>(tableRootComponent.props?.children[1]) && | ||
| typeof tableRootComponent.props?.children[1]?.props.children === 'function') as boolean; |
There was a problem hiding this comment.
This looks a little complex 🙈 Can you add comment on how this checks if table is virualized?
There was a problem hiding this comment.
refactored this. no jsx walking
Comment on lines
79
to
80
| paddingX="0" | ||
| paddingY="0" |
There was a problem hiding this comment.
This is allowed in TS 🙈 ?
There was a problem hiding this comment.
Why are these different story files? we can have one TableVirtualized.stories.tsx and add virtualized tables there right?
Comment on lines
65
to
82
| if (isVirtualized) { | ||
| if ( | ||
| React.isValidElement<{ header?: () => React.ReactElement }>(tableRootComponent) && | ||
| tableRootComponent?.props.header | ||
| ) { | ||
| if (React.isValidElement(tableRootComponent?.props.header())) { | ||
| const tableHeaderRow = tableRootComponent.props.header().props.children; | ||
| if ( | ||
| React.isValidElement<{ children?: React.ReactNode }>(tableHeaderRow) && | ||
| tableHeaderRow.props.children | ||
| ) { | ||
| const tableHeaderCells = React.Children.toArray(tableHeaderRow.props.children); | ||
| return tableHeaderCells.length; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This won't be needed as we discussed
| @@ -156,8 +199,17 @@ const _Table = <Item,>({ | |||
| undefined, | |||
| ); | |||
| const [hasHoverActions, setHasHoverActions] = React.useState(false); | |||
| const tableRootComponent = children([]); | |||
| const isVirtualized = (React.isValidElement<{ | |||
| @@ -12,6 +12,7 @@ const ComponentIds = { | |||
| TableFooter: 'TableFooter', | |||
| TableFooterRow: 'TableFooterRow', | |||
| TableFooterCell: 'TableFooterCell', | |||
| VirtualizedTable: 'VirtualizedTable', | |||
There was a problem hiding this comment.
This doesn't exist right?
There was a problem hiding this comment.
it is being used in TableVirtualizedWrapper
Comment on lines
110
to
111
| <TableBody<Item>> | ||
| {(tableItem, index) => ( |
There was a problem hiding this comment.
Suggested change
| <TableBody<Item>> | |
| {(tableItem, index) => ( | |
| <TableBody> | |
| {(tableItem: Item, index) => ( |
| {(tableData) => ( | ||
| <> | ||
| {() => ( | ||
| <TableVirtualizedWrapper rowHeight={() => 57}> |
There was a problem hiding this comment.
we can remove virtualization from Basic story I guess
| tableRootComponent.props.children?.length && | ||
| React.isValidElement<{ children?: React.ReactNode }>(tableRootComponent.props?.children[1]) && | ||
| typeof tableRootComponent.props?.children[1]?.props.children === 'function') as boolean; | ||
| const isVirtualized = getComponentId(tableRootComponent) === ComponentIds.VirtualizedTable; |
saurabhdaware
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional Information
dev checklist -
[ x ] vtable height be changed
[ x ] check why check box look weird ?
[ x ] need to make row similar to normal table
[ x ] should check the space of table.
[ x ] vtable should be aligned as normal table.
[ x ] hover actions
[ x ] sticky column
[ x ] table header
[ x ] fix ts error
[ x ] unified styles for virtualized table
[ x ] add tests
Component Checklist