Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extractor-plugins): add crawler specifications #478

Merged
merged 12 commits into from
Apr 19, 2023

Conversation

Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Mar 27, 2023

Adding option to exclude resources from being crawled from extractors

  • MongoDB
  • CouchDB
  • MySQL
  • MsSQL
  • Snowflake (TODO: edit testcases)
  • Presto
  • MariaDB
  • GCS
  • Cassandra
  • Clickhouse
  • Grafana

Note: Metabase and Snowflake API responses have changed and the meteor extractors needs to be edited to support different versions

@Chief-Rishab Chief-Rishab marked this pull request as ready for review April 4, 2023 19:13
@Chief-Rishab Chief-Rishab requested a review from kushsharma April 5, 2023 19:03
Copy link
Member

@kushsharma kushsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Minor nit: sqlutil method of building boolmap has nothing to do with SQL. Should we pull it out to plugins util? Just check if that causes cycle dependency.

@ravisuhag ravisuhag merged commit dac373f into main Apr 19, 2023
@ravisuhag ravisuhag deleted the feat/add-crawler-specifications branch April 19, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants