Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add struct tags and update docs #477

Merged
merged 3 commits into from
Mar 22, 2023
Merged

chore: add struct tags and update docs #477

merged 3 commits into from
Mar 22, 2023

Conversation

Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented Mar 15, 2023

Updating README for following plugins:

@Chief-Rishab Chief-Rishab requested a review from kushsharma March 15, 2023 13:58
@Chief-Rishab Chief-Rishab changed the title docs: update README for plugins chore: add struct tags and update docs Mar 15, 2023
@kushsharma
Copy link
Member

Extra yaml/json struct tags look alright but I do see a few extra changes like tableu identifier, what are these for?

plugins/extractors/tableau/tableau.go Show resolved Hide resolved
plugins/sinks/compass/README.md Show resolved Hide resolved
test/e2e/mysql_kafka.yml Show resolved Hide resolved
@kushsharma
Copy link
Member

LGTM

@ravisuhag ravisuhag merged commit 4c18210 into main Mar 22, 2023
@ravisuhag ravisuhag deleted the update-extractors branch March 22, 2023 17:35
@ravisuhag ravisuhag linked an issue Mar 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update README.md for labels for compass sink
3 participants