feat(columbus): add "service" field to columbus payload #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravisuhag
reviewed
Nov 4, 2021
| @@ -9,4 +9,5 @@ import ( | |||
| type Metadata interface { | |||
| GetResource() *common.Resource | |||
| GetProperties() *facets.Properties | |||
| GetLineage() *facets.Lineage | |||
There was a problem hiding this comment.
@StewartJingga This would not be applicable to every resource right? Like user.
There was a problem hiding this comment.
yes, but right now it is the only way Columbus sink is able to fetch lineage from our varies models.
The other way is to typechecking for each types which im not sure is scalable.
There was a problem hiding this comment.
@ravisuhag another approach is to have another interface for lineage and typecheck for that interface in Columbus.
type HasLineage interface {
GetLineage() *facets.Lineage
}
There was a problem hiding this comment.
I think let's create another interface for lineage check instead of expecting all models to have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.