feat: improve error handling #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StewartJingga
requested changes
Oct 2, 2021
There was a problem hiding this comment.
Love the error wrapping but needs some changes on these two things:
- Use
Wrapinstead ofWrapfif there is no string formatting. - For case where return value is already defined you can wrap error like below
if err != nil {
err = errors.Wrap(err, "wrapping error")
return
}
scortier
force-pushed
the
format-errors
branch
3 times, most recently
from
94a212d to
886318f
Compare
scortier
force-pushed
the
format-errors
branch
from
886318f to
3dee4f1
Compare
scortier
force-pushed
the
format-errors
branch
from
df786b7 to
311bdef
Compare
StewartJingga
requested changes
Oct 4, 2021
scortier
force-pushed
the
format-errors
branch
from
183c25c to
a625ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.