Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make footer year dynamic #304

Merged
merged 3 commits into from
Jan 17, 2023
Merged

fix: make footer year dynamic #304

merged 3 commits into from
Jan 17, 2023

Conversation

shrivatsabhat
Copy link
Collaborator

@shrivatsabhat shrivatsabhat commented Jan 5, 2023 •
edited
Loading

Description

Fix the footer year

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Data Results

  • none

Additional Info

  • none

@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nexus-explorer-next ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 3:57PM (UTC)

@github-actions github-actions bot added the bug label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023 •
edited
Loading

Messages
📖 Changed Files in this PR:
  1. src/types/FooterTypes.js

Generated by 🚫 dangerJS against b2e98af

rayanfer32
rayanfer32 requested changes Jan 5, 2023
View reviewed changes
Copy link
Owner

@rayanfer32 rayanfer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove null check

@shrivatsabhat shrivatsabhat self-assigned this Jan 14, 2023
@rayanfer32 rayanfer32 changed the title fix: footer year privacy fix: make footer year dynamic Jan 14, 2023
rayanfer32
rayanfer32 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@rayanfer32 rayanfer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayanfer32 rayanfer32 merged commit 10f0cbb into develop Jan 17, 2023
@shrivatsabhat shrivatsabhat deleted the fix/footer-year branch April 1, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayanfer32 rayanfer32 rayanfer32 approved these changes

Assignees

@shrivatsabhat shrivatsabhat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrivatsabhat @rayanfer32