Rayan #21
Merged
Rayan #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rayanfer32/nexus-explorer-next/DLckaZ4AgeZiDPAhsvJ4yMJvtk9Y |
shrivatsabhat
requested changes
Dec 3, 2021
|
|
||
| Rail.propTypes = { | ||
| scrollSpeed: PropTypes.number, |
There was a problem hiding this comment.
Scroll speed is optional
Don't give proptype as strictly required prop
There was a problem hiding this comment.
yes i havent made it .isRequired
| import PropTypes from 'prop-types'; | ||
|
|
||
| SearchBar.propTypes = { | ||
| type: PropTypes.oneOf(['long']), |
There was a problem hiding this comment.
Here also prop type and long are optional prop,
|
|
||
| SmallCard.propTypes = { | ||
| label: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired, | ||
| sublabel: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), |
There was a problem hiding this comment.
Sublabel is optional prop
|
I haven't kept the props as isRequired , that means they are optional only ryt. |
shrivatsabhat
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Area of change
Checklist:
npm run format/yarn formatbefore commitdevelopand merged to my branch before submitting pull requestdevelopormainbranchRelated Issue
Proposed Changes
Additional Info
Screenshots