Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic pagination for richlist WIP #167

Merged
merged 15 commits into from
May 4, 2022
Merged

Conversation

rayanfer32
Copy link
Owner

@rayanfer32 rayanfer32 commented Apr 24, 2022

Description

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor/Revamp ( rewrite or restructure code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran npm run format/yarn format before commit
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Related Issue

  • none

Proposed Changes

  • none

Additional Info

  • none

Screenshots

Original Updated

@vercel
Copy link

vercel bot commented Apr 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rayanfer32/nexus-explorer-next/2xEgraVCT4AH5mBw36vx4XTzrpBk
✅ Preview: https://nexus-explorer-next-git-feat-dynamic-richlist-rayanfer32.vercel.app

@github-actions github-actions bot added the chore chore related changes label Apr 24, 2022
@vercel
Copy link

vercel bot commented Apr 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nexus-explorer-next ✅ Ready (Inspect) Visit Preview May 3, 2022 at 10:41AM (UTC)

@rayanfer32 rayanfer32 marked this pull request as ready for review May 2, 2022 17:40
@rayanfer32 rayanfer32 requested a review from shrivatsabhat May 2, 2022 17:42
@rayanfer32 rayanfer32 marked this pull request as draft May 2, 2022 17:45
@rayanfer32 rayanfer32 marked this pull request as ready for review May 3, 2022 06:32
@rayanfer32
Copy link
Owner Author

Mostly an issue with how repl.it handles URLs , I have changed development URLs to the explorer.nexus.io API server.

<DynamicPagination controls={dynamicPageControls} />
<DynamicPagination
controls={dynamicPageControls}
isStaticPanination={false}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block is it static pagination?

}, delay);
};
clearTimeout(timeout);
timeout = setTimeout(cb, delay);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope this will not cause sideeffects

shrivatsabhat
shrivatsabhat previously approved these changes May 3, 2022
Copy link
Collaborator

@shrivatsabhat shrivatsabhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go through the comments once and proceed with merge

@shrivatsabhat shrivatsabhat added the Reviewed once review is done label May 3, 2022
@rayanfer32 rayanfer32 merged commit ca1ccca into develop May 4, 2022
@rayanfer32 rayanfer32 deleted the feat/dynamic-richlist branch May 4, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore chore related changes Reviewed once review is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants