Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta images and details #143

Merged
merged 2 commits into from
Mar 22, 2022
Merged

feat: add meta images and details #143

merged 2 commits into from
Mar 22, 2022

Conversation

shrivatsabhat
Copy link
Collaborator

@shrivatsabhat shrivatsabhat commented Mar 22, 2022

Description

added meta images for Twitter and facebook

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor/Revamp ( rewrite or restructure code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Area of change

  • Frontend
  • Backend

Checklist:

  • My code follows the style guidelines of this project
  • I ran npm run format/yarn format before commit
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • I have updated develop and merged to my branch before submitting pull request
  • My pull request generate no conflicts with develop or main branch
  • I requested code review from other team members

Related Issue

  • none

Proposed Changes

  • none

Additional Info

  • none

Screenshots

Original Updated

@shrivatsabhat shrivatsabhat added the feat added new feature label Mar 22, 2022
Copy link
Owner

@rayanfer32 rayanfer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the PageMeta in the index page aswell

@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rayanfer32/nexus-explorer-next/5XVSAD6cjutN2DrkJ24vRKnVc714
✅ Preview: https://nexus-explorer-next-git-feat-meta-rayanfer32.vercel.app

@shrivatsabhat
Copy link
Collaborator Author

Please link the PageMeta in the index page aswell

yes patch is added

@github-actions github-actions bot added the chore chore related changes label Mar 22, 2022
@shrivatsabhat shrivatsabhat merged commit 43c909a into develop Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore chore related changes feat added new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants