-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Dynamic Endless pagination for trustlist #142
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rayanfer32/nexus-explorer-next/G4sXRqPmuNbPyrkmrrADxXVwjSPu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for me
@rayanfer32 please add the total pages number it will affect user experience user will not know how many pages will be present in this case >>> |
{pageIndex + 1} of {pageCount} | ||
Page{' '} | ||
<strong> | ||
{pageIndex + 1} {pageCount != Infinity && `of ${pageCount}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is may not be working as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its working as expected
This will have a bad experience on switching to the next page, as for the next page it has to make a network request. |
Description
Type of change
Area of change
Checklist:
npm run format
/yarn format
before commitdevelop
and merged to my branch before submitting pull requestdevelop
ormain
branchRelated Issue
Proposed Changes
Additional Info
Screenshots