Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm.serving] Address dependencies related issues for llm serving #50785

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Feb 21, 2025

Why are these changes needed?

Two dependencies we are resolving that requires to pin xgrammar and pynvml to specific versions. Related vllm PR/ issues

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Feb 21, 2025
@GeneDer
Copy link
Contributor Author

GeneDer commented Feb 21, 2025

cc @kouroshHakha

@@ -2,3 +2,5 @@ pytest
aiohttp
pillow
httpx>=0.27.2
pynvml>=12.0.0
xgrammar>=0.1.11, !=0.1.13, !=0.1.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no action required)

this is fine, you can also just pin the version in the test here.

the test requirement is not exposed to user, so it is easy to update.

the non test requirement is saved in the wheel, and will become immutable after package release.

you might want to add things like !=0.1.13 in ray[llm]'s requirement, so that pip install ray[llm] has a higher chance to work for user.

@aslonnie
Copy link
Collaborator

llm tests are passing and llm images are building. I am merging this for you.

@aslonnie aslonnie merged commit d5368a8 into ray-project:master Feb 21, 2025
4 of 5 checks passed
@GeneDer GeneDer deleted the genesu/add-more-llm-dependencies branch February 21, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants