[RLlib] Cleanup default_resource_request.
#50475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
…_accelerate_11_fix_multi_node_agg_actors
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Feb 12, 2025
| bundles = [driver] + rollout_bundles + evaluation_bundles + learner_bundles | ||
| learner_bundles = [] | ||
| if config.enable_rl_module_and_learner: | ||
| learner_bundles = _get_learner_bundles(config) |
There was a problem hiding this comment.
Maybe using
if config.enable_rl_module_and_learner:
learner_bundles = _get_learner_bundles(config)
else:
learner_bundles = []for better readability.
| if worker_index == 0: | ||
| return self.env_runner_cls(**kwargs) | ||
|
|
||
| pg_bundle_idx = ( |
There was a problem hiding this comment.
Does this assignment per PG order always work?
There was a problem hiding this comment.
Let's hope so :D
Yeah, it's indexing into the first n bundles, not counting the 0th bundle for the Trial (Algorithm main process/actor). These are always EnvRunner reserved. The second m bundles - if applicable - are then eval EnvRunners.
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: Sven Mika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup
default_resource_request.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.