[RLlib] APPO accelerate (vol 10): Some torch distribution enhancements. #50440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Feb 12, 2025
| @@ -141,7 +143,7 @@ def required_input_dim(space: gym.Space, **kwargs) -> int: | |||
| def rsample(self, sample_shape=()): | |||
| if self._one_hot is None: | |||
| self._one_hot = torch.distributions.one_hot_categorical.OneHotCategorical( | |||
| logits=self.logits, probs=self.probs | |||
| logits=self.logits, probs=self.probs, validate_args=False | |||
There was a problem hiding this comment.
Interesting. So validation takes a long time? Shall we by time introduce a general configuration argument validate_args that includes validations in all such methods, like here and in gymnasium, etc.? Such it helps users in finding bugs?
There was a problem hiding this comment.
Maybe we should, yeah. Then again, don't want to add too much second-layer/wrapped config args.
I think the ultimate goal should be to try and use torch.distributions directly (in custom and default RLModules) without the RLlib wrappers.
sven1977
deleted the
appo_accelerate_10_torch_distribution_enhancements
branch
israbbani
pushed a commit
that referenced
this pull request
Feb 25, 2025
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
…s. (ray-project#50440) Signed-off-by: Jay Chia <[email protected]>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
…s. (ray-project#50440) Signed-off-by: Jay Chia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPO accelerate (vol 10): Some torch distribution enhancements.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.