-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Ray Train XGboost tutorials #50331
Conversation
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
…book Signed-off-by: Ricardo Decal <[email protected]>
* created new distributed-xgboost-lightgbm.ipynb which is a superset of the two existing tutorials * ported .rst with transcluded code snippets since it was a tangled nightmare * updated pointers in train/examples.yml to this tutorial * kept orphaned code in `doc_code/preprocessors.py` since it is part of our CI * see #50232 (comment) Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
d7e0f32
to
344e63c
Compare
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Philipp Moritz <[email protected]>
030ffd1
to
1dc757b
Compare
@crypdick Unfortunately this doesn't work since now none of the links to the .rst that were converted to .ipynb are functional any more (look at the test failures in https://buildkite.com/ray-project/microcheck/builds/11000) -- these are set by the anchor There was also a small error about a non-existant use case that I pushed a fix for :) |
@pcmoritz I am not sure why the link didn't work. For example, the Ray Data examples page links to an ipynb tutorial via the examples.yml links using the same pattern. What am I missing? |
The problem is that the tests are failing with this:
(you should be able to see this in the CI run linked from my comment) |
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
@pcmoritz ok, I've fixed 3 of the error categories. I'm stuck on the Alternatively, I found an ugly hack to create anchors by converting the ipynb notebooks, which I don't recommend. |
Does it work if you replace the labels
|
@pcmoritz now getting Also, I'm not sure why it says that I requested reviews, all I did was push a new commit |
Signed-off-by: Ricardo Decal <[email protected]>
0266526
to
a407b0b
Compare
Signed-off-by: Ricardo Decal <[email protected]>
a407b0b
to
86cb495
Compare
Signed-off-by: Ricardo Decal <[email protected]>
Signed-off-by: Ricardo Decal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes needed?
This PR merges the two existing Ray Train XGBoost tutorials, which were largely duplicated, into one.
NOTE: I am not sure that I updated the pointers to this tutorial correctly. Please double check my work in
examples.yml
Out of scope: merging the third Ray Tune XGBoost tutorial.
Related issue number
#50232 (comment)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.