[LLM Serving] add skeleton public api to ray.serve.llm #50297
Merged
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
Signed-off-by: Gene Su <[email protected]>
GeneDer
requested review from
edoakes,
zcin,
akshay-anyscale and
a team
as code owners
|
@kouroshHakha maybe you can help to do a first pass |
kouroshHakha
reviewed
Feb 7, 2025
Comment on lines
+1
to
+15
| try: | ||
| from ray.llm._internal.serve import ( | ||
| LLMConfig as _LLMConfig, | ||
| VLLMDeployment as _VLLMDeployment, | ||
| LLMModelRouterDeployment as _LLMModelRouterDeployment, | ||
| LLMServingArgs, | ||
| ) | ||
| except ImportError: | ||
| _LLMConfig = object | ||
| _VLLMDeployment = object | ||
| _LLMModelRouterDeployment = object | ||
| LLMServingArgs = object | ||
|
|
||
| from ray.serve.deployment import Application | ||
| from ray.util.annotations import PublicAPI |
There was a problem hiding this comment.
Let's define the base classes in their correct spot and not have this ImportError ? similar to #50015
There was a problem hiding this comment.
or is this gonna change in the next PR?
There was a problem hiding this comment.
It's gonna be a next PR. Was thinking to have this one just be the skeleton code
Signed-off-by: Gene Su <[email protected]>
kouroshHakha
approved these changes
Feb 7, 2025
zcin
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
add llm serving skeleton public api to ray.serve.llm and links to doc
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.