Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Include ray user-agent in BigQuery client construction #49922

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 17, 2025

Why are these changes needed?

Including something in the user-agent header indicating requests to BigQuery originated from Ray would help myself and my colleagues on the BigQuery and Vertex AI teams prioritize improvements to the Ray + BigQuery connector. This is something the BigQuery team requires of official partners and by some interpretations of the Google APIs terms of service, specifically "You will not misrepresent or mask either your identity or your API Client's identity when using the APIs or developer accounts.".

Related issue number

For example, similar changes to pandas-gbq (googleapis/python-bigquery-pandas#281) and ibis (ibis-project/ibis#2303) have helped me continue spending a portion of my working hours improving pandas and ibis.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • [N/A] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [N/A] I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests (python -m pytest -v -s python/ray/data/tests/test_bigquery.py)
    • Release tests
    • This PR is not tested :(

@tswast tswast requested a review from a team as a code owner January 17, 2025 21:15
@tswast tswast force-pushed the tswast-bigquery-user-agent branch from 123809d to 382a03e Compare January 17, 2025 21:16
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the contribution!

Would love to learn on how we can better enable your team to contribute here.

Whats the best way to connect?

@richardliaw richardliaw added data Ray Data-related issues go add ONLY when ready to merge, run all tests labels Jan 18, 2025
@richardliaw richardliaw merged commit 3bd3865 into ray-project:master Jan 18, 2025
6 checks passed
@tswast
Copy link
Contributor Author

tswast commented Jan 19, 2025

Thanks @richardliaw ! For asynchronous stuff, feel free to tag me on issues or PRs and I can chime in and/or tag in a teammate.

Feel free also to reach out to us via email. Mine is on my GitHub profile or we also monitor [email protected].

@tswast tswast deleted the tswast-bigquery-user-agent branch January 21, 2025 16:03
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants