Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fix dashboard NodeHead._update_node_stats check failure #48746

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[Dashboard] Fix dashboard NodeHead._update_node_stats check failure #48746

merged 1 commit into from
Nov 14, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Nov 14, 2024

Why are these changes needed?

# NOTE: Zip will silently truncate to shorter argument that potentially
        #       could lead to subtle hard to catch issues, hence the assertion
        assert len(node_ids) == len(responses)

will check fail if the node is dead.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao requested a review from alexeykudinkin November 14, 2024 20:24
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Nov 14, 2024
jjyao
jjyao commented Nov 14, 2024
View reviewed changes
python/ray/dashboard/modules/node/node_head.py
node_info = DataSource.nodes.get(node_id)
if node_info["state"] != "ALIVE":
continue

node_ids.append(node_id)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before node_ids contains dead nodes but get_node_stats_tasks doesn't, hence the check failure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a regression test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to test_node.py

alexeykudinkin
alexeykudinkin approved these changes Nov 14, 2024
View reviewed changes
python/ray/dashboard/modules/node/node_head.py
node_info = DataSource.nodes.get(node_id)
if node_info["state"] != "ALIVE":
continue

node_ids.append(node_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a regression test

@jjyao jjyao merged commit 2e953d3 into ray-project:master Nov 14, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/cheeee branch November 14, 2024 22:00
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
@jjyao @dentiny
[Dashboard] Fix dashboard NodeHead._update_node_stats check failure (r…
b205cab 
…ay-project#48746)

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: hjiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

Assignees

@alexeykudinkin alexeykudinkin

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @alexeykudinkin