[core] Fix wrong return type on get_actor in the state api #48695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Teixeira <[email protected]>
miguelteixeiraa
force-pushed
the
master
branch
from
ff78cd5 to
e7d4486
Compare
rynewang
approved these changes
Nov 13, 2024
|
These failed tests seem flaky. We might need to rerun buildkite/premerge |
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…ct#48695) ray.util.state.get_actor currently have a type annotation specifying that the function should return an Optional[Dict] but it actually returns [ActorState](https://github.com/ray-project/ray/blob/3141dfe4031cc715515b365278cd1d6b8955154e/python/ray/util/state/common.py#L416) (as the Docstring speficies). This pull request simply changes this type annotation. Signed-off-by: Miguel Teixeira <[email protected]> Signed-off-by: hjiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray.util.state.get_actor currently have a type annotation specifying that the function should return an Optional[Dict] but it actually returns ActorState (as the Docstring speficies). This pull request simply changes this type annotation.
Related issue number
Closes #48694
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.