[Data] Ensure all tests use shared cluster in test_csv
#48352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
8 tasks
scottjlee
approved these changes
Oct 29, 2024
| # test_write_datasink_ray_remote_args test, which uses a cluster_utils cluster, will | ||
| # fail with a double-init. | ||
| def test_csv_read_no_header(shutdown_only, tmp_path): | ||
| def test_csv_read_no_header(ray_start_regular_shared, tmp_path): |
There was a problem hiding this comment.
any ideas why it was not using the shared cluster before? i also looked at the test code but couldn't find any particular reason...
There was a problem hiding this comment.
Because there was a test (written three years ago) that depended on Ray getting shutdown. But that test isn't in this module anymore, and it calls ray.shutdown in the test itself anyway so there's no reason not to use shared clusters at this point
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…#48352) See ray-project#48228 (comment). Signed-off-by: Balaji Veeramani <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…#48352) See ray-project#48228 (comment). Signed-off-by: Balaji Veeramani <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…#48352) See ray-project#48228 (comment). Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #48228 (comment).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.