Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint #48322

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix lint #48322

merged 1 commit into from
Oct 29, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Oct 29, 2024 •
edited
Loading

Why are these changes needed?

fix router.py

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin
fix lint
f59ff68 
Signed-off-by: Cindy Zhang <[email protected]>
@zcin zcin mentioned this pull request Oct 29, 2024
Merged
8 tasks
@zcin zcin added the go add ONLY when ready to merge, run all tests label Oct 29, 2024
akyang-anyscale
akyang-anyscale approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@akyang-anyscale akyang-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zcin zcin merged commit 5e252d7 into ray-project:master Oct 29, 2024
4 of 5 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@zcin @Jay-ju
Fix lint (ray-project#48322)
e885529 
## Why are these changes needed?

fix router.py

Signed-off-by: Cindy Zhang <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@zcin @JP-sDEV
Fix lint (ray-project#48322)
6ed6973 
## Why are these changes needed?

fix router.py

Signed-off-by: Cindy Zhang <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@zcin @mohitjain2504
Fix lint (ray-project#48322)
d2c223a 
## Why are these changes needed?

fix router.py

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyang-anyscale akyang-anyscale akyang-anyscale approved these changes

@edoakes edoakes Awaiting requested review from edoakes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcin @akyang-anyscale