Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[RLlib] Upgrade to gymnasium 1.0.0 (ale_py 0.10.1, mujoco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3)."" #48308

Merged

Conversation

sven1977
Copy link
Contributor

Reverts #48297

Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 enabled auto-merge (squash) October 29, 2024 15:15
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 29, 2024
@sven1977 sven1977 added rllib RLlib related issues rllib-env rllib env related issues rllib-newstack rllib-envrunners Issues around the sampling backend of RLlib and removed go add ONLY when ready to merge, run all tests labels Oct 29, 2024
@sven1977 sven1977 disabled auto-merge October 29, 2024 15:16
@sven1977 sven1977 enabled auto-merge (squash) October 29, 2024 15:16
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 29, 2024
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sven1977 sven1977 merged commit 918bbd1 into master Oct 29, 2024
5 of 8 checks passed
@sven1977 sven1977 deleted the revert-48297-revert-45328-upgrade_gymnasium_to_1_0_0a1 branch October 29, 2024 17:36
@can-anyscale
Copy link
Collaborator

rllib tests are still failing https://buildkite.com/ray-project/release/builds/24900 so reverting this

@can-anyscale
Copy link
Collaborator

revert PR: #48435

Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
…10.1, mujoco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3).""" (ray-project#48435)

Reverts ray-project#48308
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…joco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3)."" (ray-project#48308)

Signed-off-by: JP-sDEV <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…10.1, mujoco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3).""" (ray-project#48435)

Reverts ray-project#48308
Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…joco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3)."" (ray-project#48308)

Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…10.1, mujoco 3.2.4, pettingzoo 1.24.3 supersuit 3.9.3).""" (ray-project#48435)

Reverts ray-project#48308

Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-env rllib env related issues rllib-envrunners Issues around the sampling backend of RLlib rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants