Adds timeout_ms and a new method MultiGet to InternalKVAccessor.
#45444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure feature parity of the accessor vs the PythonGcsClient, as a preparation step to replace the latter. Previously it sets all timeouts to a SYS_gcs_server_request_timeout_seconds but now we make it user controllable. Also adds a method MultiGet. Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
May 20, 2024
|
i rebased your PR to a more recent master to have better coverage in microcheck, thankks |
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
May 21, 2024
| @@ -350,7 +350,7 @@ std::unique_ptr<std::string> GlobalStateAccessor::GetInternalKV(const std::strin | |||
| absl::ReaderMutexLock lock(&mutex_); | |||
| std::string value; | |||
|
|
|||
| Status status = gcs_client_->InternalKV().Get(ns, key, value); | |||
| Status status = gcs_client_->InternalKV().Get(ns, key, /*timeout_ms=*/0, value); | |||
| @@ -88,7 +88,7 @@ TEST_F(UsageStatsClientTest, TestRecordExtraUsageTag) { | |||
| [this]() { | |||
| std::string value; | |||
| RAY_CHECK_OK(this->gcs_client_->InternalKV().Get( | |||
| "usage_stats", "extra_usage_tag__test1", value)); | |||
| "usage_stats", "extra_usage_tag__test1", /*timeout_ms=*/0, value)); | |||
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
approved these changes
May 21, 2024
|
This is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure feature parity of the accessor vs the PythonGcsClient, as a preparation step to replace the latter. Previously it sets all timeouts to a SYS_gcs_server_request_timeout_seconds but now we make it user controllable.
Semantics of the new field: for each Async methods in
accessor.h, the new field isconst int64_t timeout_ms.-1means infinite timeout;> 0means the specified timeout in milliseconds.Also adds a method MultiGet.