[release-automation] Step to build update version binary into zip and store as artifact #45363
Conversation
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
|
Tested locally with this artifact: https://buildkite.com/ray-project/release-automation/builds/486#018f7df0-673e-493d-a03d-b8534431c7b8 and running script worked (files were changed) |
|
|
||
| @click.command() | ||
| @click.option("--root_dir", required=True, type=str) |
There was a problem hiding this comment.
what should be the root_dir values provided by the users? is this script used somewhere and need to be updated?
There was a problem hiding this comment.
root_dir would be the path to Ray repository that user would want the changes to be on. For automation bot, it would clone Ray repo now and pass the path to the repo as root_dir here. If user ran the script locally, root_dir would be their Bazel workspace path.
| job_env: forge | ||
| commands: | ||
| - bazel build --build_python_zip --incompatible_use_python_toolchains=false --python_path=python //ci/ray_ci/automation:update_version | ||
| - cp bazel-bin/ci/ray_ci/automation/update_version.zip /artifact-mount/ |
There was a problem hiding this comment.
will you upload the binaries somewhere after this step? if so do you plan to automate that step too?
There was a problem hiding this comment.
I think the bot will just use buildkite API to download this from the pipeline.
There was a problem hiding this comment.
The binaries would not be uploaded anywhere else besides the build artifacts. And yes the automation bot would download this artifact using the Buildkite API (we already have a helper function just for that)
| job_env: forge | ||
| commands: | ||
| - bazel build --build_python_zip --incompatible_use_python_toolchains=false --python_path=python //ci/ray_ci/automation:update_version | ||
| - cp bazel-bin/ci/ray_ci/automation/update_version.zip /artifact-mount/ |
There was a problem hiding this comment.
I think the bot will just use buildkite API to download this from the pipeline.
| bazel_workspace_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") | ||
|
|
There was a problem hiding this comment.
can we also make this still working? like can we use this as the default value, and errors when it is empty?
There was a problem hiding this comment.
Oh yes that should be the default behavior for running locally
There was a problem hiding this comment.
updated to use bazel workspace dir as default when root_dir. If bazel workspace dir is empty, raise exception
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
| """ | ||
| Update the version in the files to the specified version. | ||
| """ | ||
| main_version, java_version = get_current_version(bazel_workspace_dir) | ||
| if not root_dir: | ||
| root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") |
There was a problem hiding this comment.
nit: don't need the ""
| if not root_dir: | ||
| root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") | ||
| if not root_dir: | ||
| raise Exception("Argument root_dir is not found.") |
There was a problem hiding this comment.
maybe say: "please specify --root_dir when not using bazelisk run" ?
Signed-off-by: khluu <[email protected]>
productrepoupdate_versionbinary into a python zip file and upload it as an artifact inrelease-automationpipelineroot_diras an arg forupdate_versionsince automation is using this on a cloned Ray repo