Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] ray-rs/prototype-v2 #21572

Closed
wants to merge 118 commits into from

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Jan 13, 2022

Why are these changes needed?

Updated view of Rust Language Worker prototype progress.

How to run the tests

cd python
sudo pip install -e . --verbose 

cd ../rust/ray-rs-examples/simple
bazel run test

CC: @rkooo567

BCC: @mwtian @ericl

Related issue number

replaces: #21363

Tracking Issue: #20609

Builds upon: #17922, cpp/src/ray/util

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kfstorm
Copy link
Member

kfstorm commented Mar 13, 2022

‼️ ACTION REQUIRED ‼️

We've updated our formatting configuration for C++ code. (see #22725)

This PR includes C++ code change. To prevent issues with merging your code, here's what you'll need to do:

  1. Merge the latest changes from upstream/master branch into your branch.
git pull upstream master
git merge upstream/master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated C++ formatting configuration.

  1. Format changed files.
scripts/format.sh
  1. Commit your changes.
git add --all
git commit -m "Format C++ code"

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 16, 2022
@stale
Copy link

stale bot commented May 1, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this May 1, 2022
@iasoon iasoon mentioned this pull request May 27, 2022
7 tasks
@crazyboycjr
Copy link

What's the state of this PR? Will ray have rust binding or support in the future?

@jjyao
Copy link
Collaborator

jjyao commented Oct 26, 2022

Hi @crazyboycjr, currently it's not prioritized but in the long term we do want to support different language bindings if there are demands.

@crazyboycjr
Copy link

Sounds good! Thanks, @jjyao for confirming this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants