-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gcs] Enable grpc based broadcasting by default #19716
[gcs] Enable grpc based broadcasting by default #19716
Conversation
This needs to be done before merging this PR:
|
Test looks good https://buildkite.com/ray-project/periodic-ci/builds/1317 |
previously I thought test failure it's related to some unit test, but it looks like system error. merge to master and re-test it. |
@rkooo567 we should keep an eye on the nightly tests after this one merged. |
I think for this particular feature, the "daily" test might give more signals than nightly. (since daily tests have higher stress tests). Can you also try running them? |
Sure, I'll run daily test before merging. |
Sadly some daily pg tests failed. Thanks, @rkooo567 for the catching. |
pg_autoscaling_regression_test
Wired thing here is that once retry they all passed |
nightly tests look good. merging to trunk and merge after ci |
blocking by this pr #19996 |
merge it since nightly looks good. |
Why are these changes needed?
This is part of redis removal project. This PR is going to enable grpc based broadcasting by default.
Related issue number
#19438
Checks
scripts/format.sh
to lint the changes in this PR.