Route core worker ERROR/FATAL logs to driver logs #18577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
commented
Sep 13, 2021
| @@ -570,13 +570,13 @@ CoreWorker::CoreWorker(const CoreWorkerOptions &options, const WorkerID &worker_ | |||
| // Retry after a delay to emulate the existing Raylet reconstruction | |||
| // behaviour. TODO(ekl) backoff exponentially. | |||
| uint32_t delay = RayConfig::instance().task_retry_delay_ms(); | |||
| RAY_LOG(ERROR) << "Will resubmit task after a " << delay | |||
| << "ms delay: " << spec.DebugString(); | |||
| RAY_LOG(INFO) << "Will resubmit task after a " << delay | |||
There was a problem hiding this comment.
Avoid excess log spam since we print a message elsewhere on retry already.
scv119
approved these changes
Sep 14, 2021
edoakes
added a commit
that referenced
this pull request
Sep 14, 2021
ericl
added a commit
to ericl/ray
that referenced
this pull request
Sep 14, 2021
…y-project#18577)" (ray-project#18602)" This reverts commit 7f8cdce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, core worker ERROR and FATAL logs are sent to
python-core-worker-*files in /tmp/ray. This makes it hard to detect error conditions and check failures, as the user only gets a message to "check logs".This change configures the spdlog to also send err+ message unconditionally to the stderr, which means the normal log routing machinery picks it up.
Related issue number
Closes #12893